Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Param private name space: handle initialized #5198

Merged
merged 1 commit into from Jul 5, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Jul 2, 2023

Parameterized objects are going to have a private namespace starting from Param 2.0 (holoviz/param#766). This PR handles the initialized attribute that is moving to this namespace.

@philippjfr let me know when you make a dev release including this PR as it will unblock holoviz/param#766.

@codecov
Copy link

codecov bot commented Jul 2, 2023

Codecov Report

Merging #5198 (25f3900) into main (f7f9ea9) will decrease coverage by 0.17%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##             main    #5198      +/-   ##
==========================================
- Coverage   83.82%   83.65%   -0.17%     
==========================================
  Files         274      274              
  Lines       39594    39600       +6     
==========================================
- Hits        33189    33127      -62     
- Misses       6405     6473      +68     
Flag Coverage Δ
ui-tests 39.52% <87.50%> (-1.02%) ⬇️
unitexamples-tests 73.77% <87.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/config.py 76.01% <87.50%> (-0.34%) ⬇️

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you!

@philippjfr philippjfr merged commit eb12414 into main Jul 5, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the param_private_namespace branch July 5, 2023 16:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants