Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement disabled parameter for editable sliders #5319

Merged
merged 2 commits into from
Jul 25, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5318

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Merging #5319 (73ac959) into main (b3faebc) will decrease coverage by 49.10%.
The diff coverage is 27.58%.

❗ Current head 73ac959 differs from pull request most recent head 2dd4741. Consider uploading reports for the commit 2dd4741 to get more accurate results

@@             Coverage Diff             @@
##             main    #5319       +/-   ##
===========================================
- Coverage   72.85%   23.75%   -49.10%     
===========================================
  Files         274      274               
  Lines       39708    39732       +24     
===========================================
- Hits        28928     9440    -19488     
- Misses      10780    30292    +19512     
Flag Coverage Δ
unitexamples-tests 23.75% <27.58%> (-49.10%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/tests/widgets/test_slider.py 8.84% <12.50%> (-90.22%) ⬇️
panel/widgets/slider.py 32.94% <46.15%> (-61.52%) ⬇️

... and 175 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit ea74dcb into main Jul 25, 2023
1 check passed
@philippjfr philippjfr deleted the fix_disabled_editable_slider branch July 25, 2023 16:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

EditableRangeSlider can not be disabled
1 participant