Allow to pass 'basic_login_template' argument to panel server #5454
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #5454 +/- ##
==========================================
+ Coverage 83.20% 83.24% +0.04%
==========================================
Files 274 274
Lines 40086 40087 +1
==========================================
+ Hits 33355 33372 +17
+ Misses 6731 6715 -16
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 3 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BasicProvider() class allows to pass custom login template to its constructor.
This change allows to pass the argument 'basic_login_template' to panel.serve() function to be used by BasicProvider class.
In my PR the argument is read from **kwargs, but this could be changed to function argument directly in get_server() function. I am not sure what is a preferable way.