Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FloatPanel reflects closed status #5466

Merged
merged 1 commit into from Sep 1, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #5438

@philippjfr philippjfr marked this pull request as ready for review September 1, 2023 09:13
@codecov
Copy link

codecov bot commented Sep 1, 2023

Codecov Report

Merging #5466 (dc04828) into main (92e3982) will decrease coverage by 0.05%.
The diff coverage is 46.15%.

@@            Coverage Diff             @@
##             main    #5466      +/-   ##
==========================================
- Coverage   72.57%   72.53%   -0.05%     
==========================================
  Files         274      275       +1     
  Lines       40111    40124      +13     
==========================================
- Hits        29109    29102       -7     
- Misses      11002    11022      +20     
Flag Coverage Δ
unitexamples-tests 72.53% <46.15%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/layout/float.py 85.71% <ø> (ø)
panel/tests/ui/layout/test_floatpanel.py 46.15% <46.15%> (ø)

... and 6 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 4c716bb into main Sep 1, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the float_panel_closed_status branch September 1, 2023 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FloatPanel Status Change on Closure
1 participant