Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement auto_grow on TextAreaInput #5592

Merged
merged 2 commits into from Oct 7, 2023
Merged

Implement auto_grow on TextAreaInput #5592

merged 2 commits into from Oct 7, 2023

Conversation

philippjfr
Copy link
Member

Supersedes #5591

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #5592 (d24184b) into main (84a3672) will increase coverage by 1.05%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5592      +/-   ##
==========================================
+ Coverage   82.47%   83.52%   +1.05%     
==========================================
  Files         275      275              
  Lines       39480    39519      +39     
==========================================
+ Hits        32560    33009     +449     
+ Misses       6920     6510     -410     
Flag Coverage Δ
ui-tests 40.80% <100.00%> (+2.16%) ⬆️
unitexamples-tests 73.49% <34.88%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/models/__init__.py 100.00% <ø> (ø)
panel/models/widgets.py 100.00% <100.00%> (ø)
panel/tests/ui/widgets/test_input.py 99.47% <100.00%> (+0.04%) ⬆️
panel/widgets/input.py 95.44% <100.00%> (+0.03%) ⬆️

... and 22 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit ebc189d into main Oct 7, 2023
14 of 15 checks passed
@philippjfr philippjfr deleted the text_area_grow branch October 7, 2023 09:00
ahuang11 pushed a commit that referenced this pull request Oct 10, 2023
* Implement auto_grow on TextAreaInput

* Add missing TS file
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant