New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix thumbnails and use Panel design on index page #5595
Conversation
Codecov Report
@@ Coverage Diff @@
## main #5595 +/- ##
==========================================
+ Coverage 73.70% 83.50% +9.79%
==========================================
Files 275 275
Lines 39549 39549
==========================================
+ Hits 29151 33024 +3873
+ Misses 10398 6525 -3873
Flags with carried forward coverage won't be shown. Click here to find out more. see 71 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
I think the top banner should be somewhat generic. When showing apps in it, there could be an expectation that the apps served can produce these. |
I had the same thought about not making apps specific. So I tried to darken the picture to only "indicate" applications. Do you have a suggestion for a better picture? |
Please review the PR if you are not satisfied with the new background picture. Just keep the old one. But the rest of the PR is still a huge improvement. I'm not able to find an idea or starting point for a better new header image. I have tried. |
No objections to the rest of the PR. I also tried to find a better image with the same luck as you. I tried with |
I'd be in favor of finding a different background image too but will go ahead and merge shortly. |
* fix thumbnails and use Panel design * fix image width * revert image url * Apply suggestions from code review * Apply suggestions from code review --------- Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
For the panel-chat-examples we are using the index page with thumbnails. The index page could need a make over because
This fixes the issues
Before
After
Todo
[ ] @philippjfr should consider replacing the existing
index_background.png
image with the below in the CDN. (see discussion below).FYI. @ahuang11