Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix thumbnails and use Panel design on index page #5595

Merged
merged 5 commits into from Oct 8, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Oct 7, 2023

For the panel-chat-examples we are using the index page with thumbnails. The index page could need a make over because

This fixes the issues

Before

panel serve app1.py app2.py --autoreload --static thumbnails=thumbnails

before

After

image

image

Todo

[ ] @philippjfr should consider replacing the existing index_background.png image with the below in the CDN. (see discussion below).

index_background

FYI. @ahuang11

@codecov
Copy link

codecov bot commented Oct 7, 2023

Codecov Report

Merging #5595 (3813a19) into main (a3ac955) will increase coverage by 9.79%.
The diff coverage is n/a.

❗ Current head 3813a19 differs from pull request most recent head c88f454. Consider uploading reports for the commit c88f454 to get more accurate results

@@            Coverage Diff             @@
##             main    #5595      +/-   ##
==========================================
+ Coverage   73.70%   83.50%   +9.79%     
==========================================
  Files         275      275              
  Lines       39549    39549              
==========================================
+ Hits        29151    33024    +3873     
+ Misses      10398     6525    -3873     
Flag Coverage Δ
ui-tests 40.81% <ø> (?)
unitexamples-tests 73.44% <ø> (-0.27%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 71 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@MarcSkovMadsen MarcSkovMadsen added this to the next milestone Oct 7, 2023
@Hoxbro
Copy link
Member

Hoxbro commented Oct 7, 2023

I think the top banner should be somewhat generic. When showing apps in it, there could be an expectation that the apps served can produce these.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Oct 7, 2023

I think the top banner should be somewhat generic. When showing apps in it, there could be an expectation that the apps served can produce these.

I had the same thought about not making apps specific. So I tried to darken the picture to only "indicate" applications.

Do you have a suggestion for a better picture?

@MarcSkovMadsen
Copy link
Collaborator Author

Please review the PR

if you are not satisfied with the new background picture. Just keep the old one. But the rest of the PR is still a huge improvement.

I'm not able to find an idea or starting point for a better new header image. I have tried.

@Hoxbro
Copy link
Member

Hoxbro commented Oct 8, 2023

No objections to the rest of the PR.

I also tried to find a better image with the same luck as you. I tried with blue generic wallpaper and ocean header.

@philippjfr
Copy link
Member

I'd be in favor of finding a different background image too but will go ahead and merge shortly.

@philippjfr philippjfr merged commit 497ad69 into main Oct 8, 2023
13 of 14 checks passed
@philippjfr philippjfr deleted the enhancement/index-thumbnails branch October 8, 2023 06:58
ahuang11 pushed a commit that referenced this pull request Oct 10, 2023
* fix thumbnails and use Panel design

* fix image width

* revert image url

* Apply suggestions from code review

* Apply suggestions from code review

---------

Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
@philippjfr philippjfr modified the milestones: next, v1.3.0 Oct 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants