Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add format to EditableFloatSlider and EditableIntSlider #5631

Merged
merged 1 commit into from Oct 13, 2023

Conversation

Hoxbro
Copy link
Member

@Hoxbro Hoxbro commented Oct 13, 2023

Fixes #5286

@codecov
Copy link

codecov bot commented Oct 13, 2023

Codecov Report

Merging #5631 (9a6f388) into main (302a6ae) will decrease coverage by 0.30%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5631      +/-   ##
==========================================
- Coverage   83.62%   83.33%   -0.30%     
==========================================
  Files         279      279              
  Lines       41343    41343              
==========================================
- Hits        34572    34452     -120     
- Misses       6771     6891     +120     
Flag Coverage Δ
ui-tests 39.02% <ø> (-0.01%) ⬇️
unitexamples-tests 74.02% <ø> (-0.28%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/widgets/slider.py 94.42% <ø> (ø)

... and 7 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@philippjfr philippjfr merged commit 3913d75 into main Oct 13, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the format_editableslider branch October 13, 2023 11:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.widgets.EditableFloatSlider format not always working
2 participants