Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for decorating async functions with pn.io.cache #5649

Merged
merged 3 commits into from Oct 16, 2023

Conversation

philippjfr
Copy link
Member

Fixes #4236

panel/io/cache.py Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Oct 16, 2023

Codecov Report

Merging #5649 (da3d86f) into main (a6dcce9) will decrease coverage by 59.50%.
Report is 4 commits behind head on main.
The diff coverage is 18.91%.

@@             Coverage Diff             @@
##             main    #5649       +/-   ##
===========================================
- Coverage   83.57%   24.08%   -59.50%     
===========================================
  Files         280      280               
  Lines       41599    41626       +27     
===========================================
- Hits        34766    10025    -24741     
- Misses       6833    31601    +24768     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 24.08% <18.91%> (-49.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/tests/io/test_cache.py 25.76% <20.00%> (-71.50%) ⬇️
panel/io/cache.py 28.18% <18.51%> (-56.12%) ⬇️

... and 221 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit cd1ba3d into main Oct 16, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the support_async_cache branch October 16, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pn.cache not working with async code: RuntimeError: cannot reuse already awaited coroutine
2 participants