Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump perspective version to 2.8.0 #5722

Merged
merged 10 commits into from
Feb 18, 2024

Conversation

limx0
Copy link
Contributor

@limx0 limx0 commented Oct 23, 2023

Perspective has gone through some nice UX updates and bug fixes since the version panel is currently on (1.9.2).

Would it be possible to bump up to the latest version?

@limx0 limx0 marked this pull request as ready for review October 23, 2023 08:09
@limx0
Copy link
Contributor Author

limx0 commented Oct 23, 2023

Currently failing on:

Error rendering Bokeh items: TypeError: Cannot read properties of undefined (reading 'worker')
    at v.render (panel.min.js?v=c47f5b18b8a430e698b9fe15e51f6119984e78334bcf3f45e210d30c37ef2f9e:130:3763)
    at c.render (bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:554:2239)
    at c.render (panel.min.js?v=c47f5b18b8a430e698b9fe15e51f6119984e78334bcf3f45e210d30c37ef2f9e:51:1136)
    at c.render (bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:554:2239)
    at c.render (bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:554:2239)
    at c.render (panel.min.js?v=c47f5b18b8a430e698b9fe15e51f6119984e78334bcf3f45e210d30c37ef2f9e:51:1136)
    at c.render_to (bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:554:6277)
    at bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:218:375
    at async f (bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:218:198)
    at async t.add_document_standalone (bokeh.min.js?v=3ca6425586de5036dc01992dd69aa61e9196dd02619557cfaeb1b3d8b77adf724be49401b1168483d165494ce57a6daa16e6f6d3660fef117d45028221f86357:218:459)

@philippjfr
Copy link
Member

Are you saying you see those errors before or after the upgrade?

@limx0
Copy link
Contributor Author

limx0 commented Oct 23, 2023

Hey @philippjfr sorry for the confusion. This is breaking on this PR and needs to be fixed.

@limx0 limx0 marked this pull request as draft October 23, 2023 12:14
@limx0
Copy link
Contributor Author

limx0 commented Oct 24, 2023

@philippjfr the issue is that perspective now requires loading the perspective module from CDN (See here).

Apologies but JS is not my thing - is there somehow in panel I can execute the import script when the component loads?

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Attention: 8 lines in your changes are missing coverage. Please review.

Comparison is base (f9d9a58) 83.65% compared to head (bc4b6d1) 83.10%.
Report is 2 commits behind head on main.

Files Patch % Lines
panel/compiler.py 0.00% 3 Missing ⚠️
panel/pane/perspective.py 66.66% 3 Missing ⚠️
panel/io/resources.py 66.66% 1 Missing ⚠️
panel/models/perspective.py 87.50% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5722      +/-   ##
==========================================
- Coverage   83.65%   83.10%   -0.56%     
==========================================
  Files         305      305              
  Lines       45518    45559      +41     
==========================================
- Hits        38079    37862     -217     
- Misses       7439     7697     +258     
Flag Coverage Δ
ui-tests 39.09% <25.00%> (-0.57%) ⬇️
unitexamples-tests 71.65% <62.50%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Not quite done here. There's two tasks remaining

  1. Figure out if we can bundle the Perspective code somehow
  2. Figure out why the console error related to syncing some option happens

@limx0 limx0 changed the title Bump perspective version to 2.6.0 Bump perspective version to 2.7.1 Dec 30, 2023
@philippjfr philippjfr changed the title Bump perspective version to 2.7.1 Bump perspective version to 2.8.0 Feb 18, 2024
@philippjfr philippjfr marked this pull request as ready for review February 18, 2024 12:25
@philippjfr philippjfr merged commit 5afbe2b into holoviz:main Feb 18, 2024
14 of 15 checks passed
@limx0
Copy link
Contributor Author

limx0 commented Feb 18, 2024

Thanks @philippjfr !

@limx0 limx0 deleted the perspective_version_bump branch February 18, 2024 20:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants