Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return None user info if no id_token #5747

Merged
merged 1 commit into from Oct 26, 2023
Merged

Return None user info if no id_token #5747

merged 1 commit into from Oct 26, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Oct 26, 2023

To fix an error I've seen in a test suite after upgrading to Panel 1.3.0

[2023-10-26T10:12:07.721Z] /usr/local/lib/python3.10/site-packages/panel/util/__init__.py:282: in decode_token
[2023-10-26T10:12:07.721Z]     if signed and "." in token:
[2023-10-26T10:12:07.721Z] E   TypeError: argument of type 'NoneType' is not iterable

@codecov
Copy link

codecov bot commented Oct 26, 2023

Codecov Report

Merging #5747 (5a4d2e8) into main (49e1cd6) will increase coverage by 1.79%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##             main    #5747      +/-   ##
==========================================
+ Coverage   82.23%   84.02%   +1.79%     
==========================================
  Files         289      289              
  Lines       42111    42113       +2     
==========================================
+ Hits        34630    35386     +756     
+ Misses       7481     6727     -754     
Flag Coverage Δ
ui-tests 40.71% <33.33%> (+2.43%) ⬆️
unitexamples-tests 73.67% <33.33%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/util/__init__.py 89.19% <100.00%> (+5.22%) ⬆️
panel/io/state.py 72.15% <0.00%> (+1.35%) ⬆️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@philippjfr philippjfr merged commit 42be52b into main Oct 26, 2023
13 checks passed
@philippjfr philippjfr deleted the handle_no_token branch October 26, 2023 13:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants