New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add serialize methods for ChatMessage + ChatFeed #5764
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
changed the title
Add serialize methods
Add serialize methods for ChatMessage + ChatFeed
Oct 27, 2023
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #5764 +/- ##
==========================================
- Coverage 84.00% 82.33% -1.67%
==========================================
Files 290 290
Lines 42391 42622 +231
==========================================
- Hits 35609 35093 -516
- Misses 6782 7529 +747
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahuang11
commented
Nov 1, 2023
ahuang11
force-pushed
the
add_serialize_methods
branch
from
November 15, 2023 10:03
d4e70c0
to
5ae65b9
Compare
philippjfr
reviewed
Nov 15, 2023
philippjfr
approved these changes
Nov 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm trying to make ChatInterface easy to use to fine tune LLMs. The first step is easy exporting of it, ready to use for transformers.
Kind of addresses #5567, but specifically for use with fine tuning transformers https://huggingface.co/docs/transformers/main/chat_templating, not ChatInterface.
I was initially thinking of combining these it like in the ChatBox export method #5178, but decided against it since the logic got long.
There's a lot of ways to serialize the widgets / panes / etc, so I added
format_func
as an escape hatch if users don't agree with the default.Would like some early thoughts before I add tests.
user
from ChatInterface inuser_names