Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Tabulator.sortable parameter #5827

Merged
merged 2 commits into from Nov 13, 2023
Merged

Add Tabulator.sortable parameter #5827

merged 2 commits into from Nov 13, 2023

Conversation

philippjfr
Copy link
Member

Adds control over the header sort of the Tabulator.

  • Add docs
  • Add tests

Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #5827 (cd86e6b) into main (b21b740) will decrease coverage by 0.04%.
Report is 15 commits behind head on main.
The diff coverage is 94.73%.

@@            Coverage Diff             @@
##             main    #5827      +/-   ##
==========================================
- Coverage   72.37%   72.34%   -0.04%     
==========================================
  Files         290      290              
  Lines       42214    42296      +82     
==========================================
+ Hits        30554    30598      +44     
- Misses      11660    11698      +38     
Flag Coverage Δ
unitexamples-tests 72.34% <94.73%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/tests/widgets/test_tables.py 99.80% <100.00%> (+<0.01%) ⬆️
panel/widgets/tables.py 87.62% <91.30%> (+0.07%) ⬆️

... and 16 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@philippjfr
Copy link
Member Author

UI test failures appear unrelated. Will fix those separately today.

@philippjfr philippjfr merged commit ba97f63 into main Nov 13, 2023
10 of 13 checks passed
@philippjfr philippjfr deleted the tabulator_sortable branch November 13, 2023 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant