Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow async callbacks on FileDownload #5878

Merged
merged 2 commits into from Nov 15, 2023
Merged

Allow async callbacks on FileDownload #5878

merged 2 commits into from Nov 15, 2023

Conversation

philippjfr
Copy link
Member

Simple change to allow FileDownload.callback to accept an async callback.

Copy link

codecov bot commented Nov 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7eb9c71) 84.00% compared to head (86bb1d4) 84.00%.
Report is 1 commits behind head on main.

Files Patch % Lines
panel/widgets/misc.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5878      +/-   ##
==========================================
- Coverage   84.00%   84.00%   -0.01%     
==========================================
  Files         290      290              
  Lines       42391    42409      +18     
==========================================
+ Hits        35609    35624      +15     
- Misses       6782     6785       +3     
Flag Coverage Δ
ui-tests 40.88% <28.57%> (-0.02%) ⬇️
unitexamples-tests 72.36% <96.42%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit f73973d into main Nov 15, 2023
13 checks passed
@philippjfr philippjfr deleted the async_filedownload branch November 15, 2023 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant