Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure DynamicMap updates when widget dimension has unit #5904

Merged
merged 2 commits into from Nov 21, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5900

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (182b51c) 84.12% compared to head (ceca79f) 84.08%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5904      +/-   ##
==========================================
- Coverage   84.12%   84.08%   -0.04%     
==========================================
  Files         291      291              
  Lines       42655    42669      +14     
==========================================
- Hits        35884    35879       -5     
- Misses       6771     6790      +19     
Flag Coverage Δ
ui-tests 40.80% <14.28%> (-0.02%) ⬇️
unitexamples-tests 72.51% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit c5206bb into main Nov 21, 2023
13 checks passed
@philippjfr philippjfr deleted the hv_widget_unit_fix branch November 21, 2023 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Intempestive call with None args in DynamicMaps if hv.Dimension with unit is provided
1 participant