Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only set text_align on index formatter if it has the attribute #5922

Merged
merged 1 commit into from
Nov 27, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 27, 2023

Fixes #5915

Copy link

codecov bot commented Nov 27, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (e3fdd48) 84.15% compared to head (afc658f) 84.41%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5922      +/-   ##
==========================================
+ Coverage   84.15%   84.41%   +0.25%     
==========================================
  Files         291      291              
  Lines       42786    42793       +7     
==========================================
+ Hits        36007    36124     +117     
+ Misses       6779     6669     -110     
Flag Coverage Δ
ui-tests 40.92% <25.00%> (-0.01%) ⬇️
unitexamples-tests 72.68% <100.00%> (+0.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 16f876a into main Nov 27, 2023
12 of 13 checks passed
@philippjfr philippjfr deleted the formatter_index branch November 27, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In the Tabulator of panel 1.3.2, using HTMLTemplateFormatter for the Index now raises an exception.
2 participants