Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not make Vega width/height responsive if fixed value is set #5940

Merged
merged 1 commit into from
Nov 29, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5918

Copy link

codecov bot commented Nov 29, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (39ec575) 82.41% compared to head (1ec3162) 84.24%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5940      +/-   ##
==========================================
+ Coverage   82.41%   84.24%   +1.82%     
==========================================
  Files         291      291              
  Lines       43055    43068      +13     
==========================================
+ Hits        35485    36281     +796     
+ Misses       7570     6787     -783     
Flag Coverage Δ
ui-tests 41.06% <25.00%> (+2.44%) ⬆️
unitexamples-tests 72.23% <100.00%> (+0.28%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 4720d6b into main Nov 29, 2023
12 of 13 checks passed
@philippjfr philippjfr deleted the vega_height branch November 29, 2023 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Vega pane does not respect height setting
1 participant