Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken links #5988

Merged
merged 2 commits into from Dec 27, 2023
Merged

Fix broken links #5988

merged 2 commits into from Dec 27, 2023

Conversation

MarcSkovMadsen
Copy link
Collaborator

If I can figure out how to fix links this closes #5983

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Dec 5, 2023

I've started a docs build in https://github.com/holoviz/panel/actions/runs/7096210521. Then I can see if these changes fixes broken links.

Copy link

codecov bot commented Dec 5, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (573497c) 84.65% compared to head (3c6fe84) 84.25%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5988      +/-   ##
==========================================
- Coverage   84.65%   84.25%   -0.40%     
==========================================
  Files         291      291              
  Lines       43458    43458              
==========================================
- Hits        36788    36615     -173     
- Misses       6670     6843     +173     
Flag Coverage Δ
ui-tests 40.78% <ø> (-0.04%) ⬇️
unitexamples-tests 72.32% <ø> (-0.41%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

Looking at the dev docs it seems like these kind of links will fix the issues.

image

@philippjfr philippjfr marked this pull request as ready for review December 27, 2023 22:24
@philippjfr philippjfr merged commit 0717965 into main Dec 27, 2023
13 of 14 checks passed
@philippjfr philippjfr deleted the fix/broken-links branch December 27, 2023 22:24
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lots of broken links from 'docs' to 'examples'
3 participants