Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correctly set error page to be rendered #6014

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Conversation

mitulb
Copy link
Contributor

@mitulb mitulb commented Dec 8, 2023

Correctly sets the error page to be rendered when authorize_callback returns False.

Repro

import panel as pn

def authorize(user_info):
    return False

pn.config.authorize_callback = authorize

pn.Row("hello world").servable()

I would expect running the above with oidc provider "generic" to return the error page however I get a 500 internal server error with the following in the logs

TypeError: write() only accepts bytes, unicode, and dict objects

Correctly sets the error page to be rendered when authorize_callback returns False
@philippjfr
Copy link
Member

Thank you!

@philippjfr philippjfr merged commit 5d6017f into holoviz:main Dec 8, 2023
1 check passed
philippjfr pushed a commit that referenced this pull request Dec 12, 2023
Correctly sets the error page to be rendered when authorize_callback returns False
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants