Add toggle icon #6034
Merged
Add toggle icon #6034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6034 +/- ##
==========================================
+ Coverage 84.67% 84.70% +0.03%
==========================================
Files 291 295 +4
Lines 43816 43885 +69
==========================================
+ Hits 37101 37173 +72
+ Misses 6715 6712 -3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Good start! Next we probably have to create and sync a bunch properties between this wrapper and the underlying icon model. |
|
Okay this is ready for the next release I think! Feel free to make changes directly as needed. A couple notes for future enhancements: #6037
ToggleIcon Screen.Recording.2023-12-13.at.7.52.38.PM.movChatMessage (made it more efficient!) Screen.Recording.2023-12-13.at.7.54.56.PM.mov |
ahuang11
commented
Dec 14, 2023
philippjfr
reviewed
Dec 14, 2023
philippjfr
reviewed
Dec 14, 2023
philippjfr
reviewed
Dec 14, 2023
philippjfr
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6022
To be used for ChatReactionIcons