Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix periodic async callbacks #6053

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Fix periodic async callbacks #6053

merged 2 commits into from
Dec 15, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5986

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (46ea554) 84.61% compared to head (56b8af7) 84.69%.
Report is 1 commits behind head on main.

Files Patch % Lines
panel/io/callbacks.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6053      +/-   ##
==========================================
+ Coverage   84.61%   84.69%   +0.08%     
==========================================
  Files         295      295              
  Lines       43936    43949      +13     
==========================================
+ Hits        37175    37224      +49     
+ Misses       6761     6725      -36     
Flag Coverage Δ
ui-tests 40.66% <17.64%> (-0.01%) ⬇️
unitexamples-tests 72.83% <94.11%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit a9a5067 into main Dec 15, 2023
11 of 13 checks passed
@philippjfr philippjfr deleted the fix_periodic_async branch December 15, 2023 12:58
philippjfr added a commit that referenced this pull request Dec 15, 2023
* Do not resolve references on PeriodicCallback

* Add tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Regression: Async PeriodicCallback coroutines no longer function.
1 participant