Do no update objects inplace unless explicitly requested #6055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6055 +/- ##
==========================================
- Coverage 83.11% 83.07% -0.05%
==========================================
Files 295 295
Lines 43960 43956 -4
==========================================
- Hits 36539 36516 -23
- Misses 7421 7440 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an attempt to be clever and optimize updates to objects we added some internal handling that would copy the returned object from a dynamically rendered function or method and then update it inplace. The major problem with this approach is that if the user has a handle on the original object any changes they make to it won't be propagated to the rendered object. Since we now have support for parameter references throughout and are slowly updating our guidance to make users aware of the efficiency gains of providing a reference to a component to update it's parameters I think it is fine to remove this optimization and thereby fix a range of bugs.
Fixes #6044
Fixes #6043
Fixes #6042