Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Auth: execute async scheduled refresh callback #6084

Merged
merged 1 commit into from
Dec 19, 2023

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented Dec 18, 2023

refresh_cb is a partial built from the _scheduled_refresh async method, it cannot be called directly.

Copy link

codecov bot commented Dec 18, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (0824f9c) 82.98% compared to head (d9d744d) 84.60%.

Files Patch % Lines
panel/auth.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6084      +/-   ##
==========================================
+ Coverage   82.98%   84.60%   +1.62%     
==========================================
  Files         295      295              
  Lines       44038    44038              
==========================================
+ Hits        36543    37260     +717     
+ Misses       7495     6778     -717     
Flag Coverage Δ
ui-tests 40.58% <0.00%> (+2.42%) ⬆️
unitexamples-tests 72.70% <0.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Looks like 1.3.6 is in the near future :)

@philippjfr philippjfr merged commit fcad239 into main Dec 19, 2023
12 of 13 checks passed
@philippjfr philippjfr deleted the execute_async_refresh branch December 19, 2023 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants