Fix chat reaction icons value events + justify-content #6086
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahuang11
changed the title
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6086 +/- ##
==========================================
+ Coverage 82.98% 84.66% +1.68%
==========================================
Files 295 296 +1
Lines 44038 44057 +19
==========================================
+ Hits 36543 37301 +758
+ Misses 7495 6756 -739
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
philippjfr
approved these changes
Dec 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly trigger value by setting self.value since append/remove does not trigger value; this fixes #6085
Also, multiple reaction icons + justify-content CSS caused it to shift upward:
After:
