Add explicit size option to ToggleIcon #6092
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6092 +/- ##
=======================================
Coverage 84.66% 84.67%
=======================================
Files 296 296
Lines 44057 44073 +16
=======================================
+ Hits 37302 37318 +16
Misses 6755 6755
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ahuang11
reviewed
Dec 20, 2023
| "cell_type": "markdown", | ||
| "metadata": {}, | ||
| "source": [ | ||
| "The icon will automatically adapt to the specified `width`/`height` but you may also provide an explicit `size`:" |
There was a problem hiding this comment.
Suggested change
| "The icon will automatically adapt to the specified `width`/`height` but you may also provide an explicit `size`:" | |
| "The icon will automatically adapt to the specified `width`/`height` but you may also provide an explicit `size` which takes precedence:" |
ahuang11
approved these changes
Dec 20, 2023
philippjfr
added a commit
that referenced
this pull request
Dec 20, 2023
* Add explicit size option to ToggleIcon * Add tests * Remove line-height around icons
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ToggleIconnow allows eitherwidth/heightor an explicit size to be defined.