Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load loading indicator from file instead of inlining #6112

Merged
merged 3 commits into from
Dec 22, 2023

Conversation

philippjfr
Copy link
Member

The loading indicators displayed on top of components were thus far always inlined as a stylesheet on each component. This is tremendously inefficient and also unnecessary to a certain extent. This change will load the SVG files either from CDN or from the local /static endpoint like all other other CSS assets. The trick we are using here is to use a CSS -image-mask and then set the background-color using an inlined stylesheet. This does mean we can no longer set a separate low opacity gray background to indicate that the component is temporarily disabled or unresponsive.

I'm still playing with alternative approaches but my basic idea is to use a CSS filter, starting with a blur filter.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (7f25eb1) 84.67% compared to head (2739db9) 84.66%.
Report is 1 commits behind head on main.

❗ Current head 2739db9 differs from pull request most recent head 1773a45. Consider uploading reports for the commit 1773a45 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6112      +/-   ##
==========================================
- Coverage   84.67%   84.66%   -0.01%     
==========================================
  Files         296      296              
  Lines       44100    44096       -4     
==========================================
- Hits        37341    37335       -6     
- Misses       6759     6761       +2     
Flag Coverage Δ
ui-tests 40.68% <0.00%> (-0.01%) ⬇️
unitexamples-tests 72.67% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 07414e9 into main Dec 22, 2023
2 checks passed
@philippjfr philippjfr deleted the loading_svg_assets branch December 22, 2023 15:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant