Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fast tabulator links #6146

Merged
merged 2 commits into from Jan 10, 2024
Merged

Fix fast tabulator links #6146

merged 2 commits into from Jan 10, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

Closes #6145

Looks like below after fix

fast-fixes.mp4

Copy link

codecov bot commented Jan 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46e0639) 84.69% compared to head (352ad56) 83.09%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6146      +/-   ##
==========================================
- Coverage   84.69%   83.09%   -1.61%     
==========================================
  Files         296      296              
  Lines       44184    44184              
==========================================
- Hits        37420    36713     -707     
- Misses       6764     7471     +707     
Flag Coverage Δ
ui-tests 38.29% <ø> (-2.44%) ⬇️
unitexamples-tests 72.55% <ø> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit aa6dd53 into main Jan 10, 2024
11 of 15 checks passed
@philippjfr philippjfr deleted the fix/fast-tabulator-links branch January 10, 2024 00:04
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot read links in Tabulator table when using Fast Template
2 participants