Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually pass card_params into ChatFeed's internal Card #6154

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 4, 2024

Addresses https://github.com/Quansight/ragna/pull/261/files/716373b2e6d51c9a74c8065d2cf1414b87115981#diff-3caa7ff25182aa89f6a4e030b8004c8666a48de3c2d496008192393eec29b618R423

import panel as pn

pn.extension()

pn.chat.ChatFeed(
    "Hello",
    card_params={"header_background": "red", "header": "Test", "hide_header": False},
).show()
image

Copy link

codecov bot commented Jan 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (46e0639) 84.69% compared to head (ed8ef0f) 84.69%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6154      +/-   ##
==========================================
- Coverage   84.69%   84.69%   -0.01%     
==========================================
  Files         296      296              
  Lines       44184    44195      +11     
==========================================
+ Hits        37420    37429       +9     
- Misses       6764     6766       +2     
Flag Coverage Δ
ui-tests 40.72% <23.07%> (-0.01%) ⬇️
unitexamples-tests 72.62% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 changed the title Add expected behavior for card param Actually pass card_params into ChatFeed's internal Card Jan 4, 2024
@philippjfr philippjfr merged commit 2e80565 into main Jan 9, 2024
15 checks passed
@philippjfr philippjfr deleted the implement_card_params branch January 9, 2024 13:06
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
* Add expected behavior for card param

* Allow dynamic updates
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants