Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix per_session caching #6169

Merged
merged 2 commits into from
Jan 12, 2024
Merged

fix per_session caching #6169

merged 2 commits into from
Jan 12, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Jan 7, 2024

Closes #6168

Todo:

  • Add test (I don't know how).

@MarcSkovMadsen MarcSkovMadsen added this to the v1.3.7 milestone Jan 7, 2024
panel/io/cache.py Outdated Show resolved Hide resolved
@MarcSkovMadsen MarcSkovMadsen changed the title fix per session fix per_session caching Jan 7, 2024
Copy link

codecov bot commented Jan 7, 2024

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (eac968a) 22.35% compared to head (1be8e66) 84.38%.
Report is 2 commits behind head on main.

Files Patch % Lines
panel/io/cache.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6169       +/-   ##
===========================================
+ Coverage   22.35%   84.38%   +62.03%     
===========================================
  Files         299      299               
  Lines       44647    44666       +19     
===========================================
+ Hits         9980    37693    +27713     
+ Misses      34667     6973    -27694     
Flag Coverage Δ
ui-tests 40.67% <22.72%> (?)
unitexamples-tests 72.19% <86.36%> (+49.84%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a test

@philippjfr philippjfr merged commit 86ca4df into main Jan 12, 2024
15 checks passed
@philippjfr philippjfr deleted the fix/per-session branch January 12, 2024 16:20
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Caching per_session not working
2 participants