Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Textual pane #6181

Merged
merged 3 commits into from
Jan 12, 2024
Merged

Add Textual pane #6181

merged 3 commits into from
Jan 12, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 11, 2024

textual_app

  • Add tests
  • Disconnect the app from the event loop when all views are deleted

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

Attention: 89 lines in your changes are missing coverage. Please review.

Comparison is base (445ff15) 84.70% compared to head (b0c63e5) 84.50%.
Report is 7 commits behind head on main.

Files Patch % Lines
panel/pane/_textual.py 0.00% 69 Missing ⚠️
panel/pane/textual.py 66.66% 20 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6181      +/-   ##
==========================================
- Coverage   84.70%   84.50%   -0.21%     
==========================================
  Files         296      298       +2     
  Lines       44320    44568     +248     
==========================================
+ Hits        37542    37661     +119     
- Misses       6778     6907     +129     
Flag Coverage Δ
ui-tests 40.82% <21.21%> (+0.09%) ⬆️
unitexamples-tests 72.26% <32.57%> (-0.36%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator

Does this "just work" in a multiuser setting. Anything users need to be aware of?

@philippjfr
Copy link
Member Author

Does this "just work" in a multiuser setting. Anything users need to be aware of?

Yep, works just fine. Nothing that I can think of, it's really all quite simple and transparent. I'll come back to this tomorrow and make sure that the apps are cleaned up properly etc.

@philippjfr philippjfr merged commit b8f102d into main Jan 12, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the textual_pane branch January 12, 2024 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants