Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ploomber Cloud deployment documentation #6182

Merged
merged 5 commits into from
Jan 12, 2024

Conversation

neelasha23
Copy link
Contributor

@neelasha23 neelasha23 commented Jan 11, 2024

Added deployment guide for Ploomber Cloud.

@edublancas
Copy link

@philippjfr: as discussed, here's the PR, let us know what you think!

@neelasha23 neelasha23 marked this pull request as ready for review January 11, 2024 15:54
@philippjfr
Copy link
Member

Thank you @neelasha23 and @edublancas. My only bit of feedback is that it might be nice to include a screenshot of this page:

Screenshot 2024-01-11 at 18 53 22

Copy link

codecov bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (445ff15) 84.70% compared to head (b3d14fd) 40.17%.
Report is 4 commits behind head on main.

❗ Current head b3d14fd differs from pull request most recent head ba90ac4. Consider uploading reports for the commit ba90ac4 to get more accurate results

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6182       +/-   ##
===========================================
- Coverage   84.70%   40.17%   -44.54%     
===========================================
  Files         296      296               
  Lines       44320    44306       -14     
===========================================
- Hits        37542    17799    -19743     
- Misses       6778    26507    +19729     
Flag Coverage Δ
ui-tests 40.17% <ø> (-0.56%) ⬇️
unitexamples-tests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Sorry, could we swap out the current image with this version reducing the size from 440 KB to 110 KB.

ploomber_deployment (1)

@neelasha23
Copy link
Contributor Author

Sorry, could we swap out the current image with this version reducing the size from 440 KB to 110 KB.

No issues. Updated the image with the latest one @philippjfr

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate, thanks so much for your contribution!

@philippjfr philippjfr merged commit 07fd37b into holoviz:main Jan 12, 2024
1 check passed
@edublancas
Copy link

@philippjfr thanks a lot!

are docs deployed on each panel release? We'd like to link from our docs to panel's docs but it seems like the changes from this PR are not visible yet

@philippjfr
Copy link
Member

Not deployed yet, but I'm planning to release 1.3.7 with these changes tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants