Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure ChatMessage internals are visible to Panel #6304

Merged
merged 1 commit into from
Feb 4, 2024
Merged

Conversation

philippjfr
Copy link
Member

Fixes #6300

Copy link

codecov bot commented Feb 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (1a0a670) 82.50% compared to head (9f4e222) 82.65%.
Report is 2 commits behind head on main.

Files Patch % Lines
panel/chat/message.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6304      +/-   ##
==========================================
+ Coverage   82.50%   82.65%   +0.14%     
==========================================
  Files         305      305              
  Lines       45419    45421       +2     
==========================================
+ Hits        37475    37542      +67     
+ Misses       7944     7879      -65     
Flag Coverage Δ
ui-tests 38.55% <50.00%> (+0.21%) ⬆️
unitexamples-tests 71.71% <50.00%> (+0.08%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 9c8ddba into main Feb 4, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the chat_msg_select branch February 4, 2024 17:43
pierrotsmnrd added a commit to Quansight/ragna that referenced this pull request Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Modifiers not applied on ChatMessage buttons
1 participant