Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove animation from loading spinner without spin #6324

Merged
merged 1 commit into from Feb 8, 2024
Merged

Conversation

Hoxbro
Copy link
Member

@Hoxbro Hoxbro commented Feb 8, 2024

Fixes #6321

Animation is set on: :host(.loader.spin) div::after {

import panel as pn

pn.extension()
active = pn.indicators.LoadingSpinner(
    width=100, height=100, bgcolor="dark", value=True, color="primary"
)
idle = pn.indicators.LoadingSpinner(
    width=100, height=100, bgcolor="dark", value=False, color="primary"
)
pn.Row(active, idle).servable()
screenrecord-2024-02-08_12.51.44.mp4

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1e8e6af) 71.67% compared to head (30a17e9) 82.64%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6324       +/-   ##
===========================================
+ Coverage   71.67%   82.64%   +10.97%     
===========================================
  Files         305      305               
  Lines       45445    45445               
===========================================
+ Hits        32572    37558     +4986     
+ Misses      12873     7887     -4986     
Flag Coverage Δ
ui-tests 38.57% <ø> (?)
unitexamples-tests 71.66% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit f1d1d37 into main Feb 8, 2024
12 of 15 checks passed
@philippjfr philippjfr deleted the spin_fix branch February 8, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Loading Spinner does not respect value kwarg
2 participants