Add chat area input and integrate #6379
Conversation
There was a problem hiding this comment.
My immediate feeling here is that we should reserve ChatAreaInput until we have a more complete and polished component with an inline send button rather than adding it simply for shift-Enter support. Also I don't think we should reset value/value_input on the Python side, I'd rather create a ChatMessageEvent that contains the value of the message and syncs the value with the value parameter on submit, while JS resets value and value_input.
Conda wasn't finding bokeh==3.4.0.dev8 which is in the dependency reqiurements. For me needs this other channel.
Bumps [cryptography](https://github.com/pyca/cryptography) from 42.0.2 to 42.0.4. - [Changelog](https://github.com/pyca/cryptography/blob/main/CHANGELOG.rst) - [Commits](pyca/cryptography@42.0.2...42.0.4) --- updated-dependencies: - dependency-name: cryptography dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
Discussed with Philipp; we agreed that we can enhance ChatAreaInput over time since drop files is supported in text area (I think) |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6379 +/- ##
==========================================
+ Coverage 83.63% 83.66% +0.03%
==========================================
Files 305 309 +4
Lines 45594 45745 +151
==========================================
+ Hits 38132 38274 +142
- Misses 7462 7471 +9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Closes #6284
Upon clicking shift enter, triggers
value. (Actually I should probably remove the shift to be consistent with ChatGPT).Something seems fishy about handling both
value_input&value. Need to double check logic it doesn't trigger something twice, but other than that pretty exciting!Screen.Recording.2024-02-22.at.10.36.28.PM.mov