Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Editable slider to be embedded #6391

Merged
merged 2 commits into from
Feb 26, 2024
Merged

Allow Editable slider to be embedded #6391

merged 2 commits into from
Feb 26, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6374

Copy link

codecov bot commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.66%. Comparing base (d6c6814) to head (46f86bc).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6391      +/-   ##
==========================================
+ Coverage   83.63%   83.66%   +0.02%     
==========================================
  Files         305      305              
  Lines       45605    45664      +59     
==========================================
+ Hits        38141    38203      +62     
+ Misses       7464     7461       -3     
Flag Coverage Δ
ui-tests 39.61% <4.91%> (-0.06%) ⬇️
unitexamples-tests 71.66% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 6db6d81 into main Feb 26, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the embed_editable branch February 26, 2024 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Embedding editable sliders fails (EditableFloatSlider, EditableIntSlider)
1 participant