Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for layout caching and sizing #6446

Merged
merged 3 commits into from
Mar 6, 2024
Merged

Fixes for layout caching and sizing #6446

merged 3 commits into from
Mar 6, 2024

Conversation

philippjfr
Copy link
Member

Layouts use various approaches for caching internal bokeh models and panes. This PR ensures that we use that cache if available, even if the object isn't currently displayed.

Copy link

codecov bot commented Mar 6, 2024

Codecov Report

Attention: Patch coverage is 85.71429% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 82.04%. Comparing base (40a6459) to head (e0fe3b2).

Files Patch % Lines
panel/layout/feed.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6446      +/-   ##
==========================================
- Coverage   82.10%   82.04%   -0.06%     
==========================================
  Files         310      310              
  Lines       45927    45928       +1     
==========================================
- Hits        37708    37682      -26     
- Misses       8219     8246      +27     
Flag Coverage Δ
ui-tests 36.33% <28.57%> (-0.24%) ⬇️
unitexamples-tests 71.63% <85.71%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 0621ac3 into main Mar 6, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the ref_check branch March 6, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant