Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add stylesheet to fileinput button #6479

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Add stylesheet to fileinput button #6479

merged 1 commit into from
Mar 11, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 11, 2024

Resolves #6475

I don't know if this is the best place to put the CSS in.

image

Code in the original issue.

Copy link

codecov bot commented Mar 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.10%. Comparing base (08f8039) to head (2b1d307).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6479       +/-   ##
===========================================
+ Coverage   71.56%   82.10%   +10.53%     
===========================================
  Files         310      312        +2     
  Lines       45996    46048       +52     
===========================================
+ Hits        32917    37807     +4890     
+ Misses      13079     8241     -4838     
Flag Coverage Δ
ui-tests 36.66% <100.00%> (?)
unitexamples-tests 71.51% <100.00%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 339ade7 into main Mar 11, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the fileinput-button branch March 11, 2024 14:51
@monodera
Copy link
Contributor

This change seems to affect the other templates as well and to me these does not look nice.

Without template:
Screenshot 2024-03-28 at 14 58 32

With Material template:
Screenshot 2024-03-28 at 14 57 56

Is it possible to revert it for other templates and make the change specific to the bootstrap template (if it's not an intension)?

@hoxbro
Copy link
Member Author

hoxbro commented Mar 29, 2024

I'm not sure what you dislike... Is it the height? If so, I don't think this PR changed that behavior. Try commenting out the stylesheets line to see if that restores the behavior.

@monodera
Copy link
Contributor

I'm sorry that I forgot to show the one with Panel 1.3.8 (shown below).

Screenshot 2024-03-28 at 22 36 23

What I don't like for the 1.4 style is the horizontal space from the left edge of the input box to the Browse button. For the Bootstrap theme, the space is equally distributed at the left, top, and bottom, but for (at least) Material and the default templates, the top and bottom paddings are zero. I feel some lack of consistency for the treatment of margins between templates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make FileInput Button adhere to the design
3 participants