Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add title and settings and fix datetime to Perspective #6482

Merged
merged 5 commits into from
Mar 12, 2024

Conversation

philippjfr
Copy link
Member

Fixes remaining issues in #5081

Copy link

codecov bot commented Mar 12, 2024

Codecov Report

Attention: Patch coverage is 57.14286% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 82.08%. Comparing base (8a7e6b0) to head (aa70954).

Files Patch % Lines
panel/pane/perspective.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6482      +/-   ##
==========================================
- Coverage   82.08%   82.08%   -0.01%     
==========================================
  Files         312      312              
  Lines       46118    46122       +4     
==========================================
+ Hits        37855    37858       +3     
- Misses       8263     8264       +1     
Flag Coverage Δ
ui-tests 36.63% <28.57%> (-0.01%) ⬇️
unitexamples-tests 71.50% <57.14%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 63f2cdb into main Mar 12, 2024
14 of 15 checks passed
@philippjfr philippjfr deleted the perspective_fix branch March 12, 2024 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant