Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix binary serialization from JS -> Pyodide #6490

Merged
merged 9 commits into from
Mar 14, 2024
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 13, 2024

Recent versions of Bokeh made two changes that are causing issues for the pyodide bi-directional syncing:

  1. JS -> Python communication can now include binary buffers
  2. JS events no longer include a setter causing events to boomerang

This PR handles both issues by:

  • Adding a converter for the binary data in the FFI layer of JS -> Python conversion

  • Setting a locking variable that prevents events from boomeranging while the serialization is in process

  • Fixes Update Pyscript version #6080

@philippjfr philippjfr added this to the v1.4.0 milestone Mar 13, 2024
Copy link

codecov bot commented Mar 13, 2024

Codecov Report

Attention: Patch coverage is 10.76923% with 58 lines in your changes are missing coverage. Please review.

Project coverage is 71.38%. Comparing base (5578f98) to head (37ccc10).
Report is 1183 commits behind head on main.

Files Patch % Lines
panel/io/pyodide.py 0.00% 42 Missing ⚠️
panel/io/convert.py 27.27% 16 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6490       +/-   ##
===========================================
- Coverage   82.75%   71.38%   -11.37%     
===========================================
  Files         239      314       +75     
  Lines       34507    46351    +11844     
===========================================
+ Hits        28555    33088     +4533     
- Misses       5952    13263     +7311     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 71.38% <10.76%> (-2.47%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/io/pyodide.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 6b39a46 into main Mar 14, 2024
12 of 15 checks passed
@philippjfr philippjfr deleted the pyodide_serialization branch March 14, 2024 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant