Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Small improvements to the PDF model #6538

Merged
merged 3 commits into from
Mar 21, 2024
Merged

Small improvements to the PDF model #6538

merged 3 commits into from
Mar 21, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 21, 2024

I had problems loading PDFs larger than 2 MB. I thought I had fixed this with: #3696

I did, but in #4452 embed was changed from True to False in the Panel class, making the problem reappear. I have updated the Bokeh model to reflect this.

As I already was in the file I did some minor updates to styling.

Also, set the embed src to always have a size of 100% in width and height. So the container is what defines the size.

@hoxbro
Copy link
Member Author

hoxbro commented Mar 21, 2024

An alternative is we set embed as True for the PDF class.

Copy link

codecov bot commented Mar 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.89%. Comparing base (9641c9b) to head (4aa9371).
Report is 4 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6538      +/-   ##
==========================================
+ Coverage   81.86%   82.89%   +1.03%     
==========================================
  Files         313      313              
  Lines       45931    45950      +19     
==========================================
+ Hits        37600    38089     +489     
+ Misses       8331     7861     -470     
Flag Coverage Δ
ui-tests 40.08% <100.00%> (+3.04%) ⬆️
unitexamples-tests 71.12% <100.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

An alternative is we set embed as True for the PDF class.

No I think this is right.

@philippjfr philippjfr merged commit 8303968 into main Mar 21, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the pdf_enhance branch March 21, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants