Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pre-load component CSS #6563

Merged
merged 8 commits into from
Mar 24, 2024
Merged

Pre-load component CSS #6563

merged 8 commits into from
Mar 24, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Mar 24, 2024

To make sure that by the time we render components all CSS resources are already cached we load all CSS files of the initially rendered components. Additionally we ensure that we now compile all CSS that directly corresponds to a single model, i.e. Plotly and Card.

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

Attention: Patch coverage is 22.22222% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 40.21%. Comparing base (c0585da) to head (2e64831).
Report is 2 commits behind head on main.

Files Patch % Lines
panel/template/base.py 0.00% 11 Missing ⚠️
panel/tests/test_server.py 20.00% 4 Missing ⚠️
panel/theme/base.py 0.00% 2 Missing ⚠️
panel/io/resources.py 66.66% 1 Missing ⚠️
panel/models/perspective.py 0.00% 1 Missing ⚠️
panel/pane/perspective.py 0.00% 1 Missing ⚠️
panel/tests/pane/test_holoviews.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6563       +/-   ##
===========================================
- Coverage   82.97%   40.21%   -42.76%     
===========================================
  Files         313      313               
  Lines       46014    46021        +7     
===========================================
- Hits        38180    18508    -19672     
- Misses       7834    27513    +19679     
Flag Coverage Δ
ui-tests 40.04% <22.22%> (-0.03%) ⬇️
unitexamples-tests 22.20% <11.11%> (-49.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 01b4d07 into main Mar 24, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the css_preload branch March 24, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant