Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve layout builder docs #6601

Merged
merged 11 commits into from
Mar 28, 2024
Merged

Improve layout builder docs #6601

merged 11 commits into from
Mar 28, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Mar 28, 2024

Partly adresses #6600.

Todo

  • Fix bugs identified [Philipp]
  • Hide "Save" Button when in Jupyter Panel Preview mode [Philipp]

Copy link

codecov bot commented Mar 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.97%. Comparing base (2a35d9c) to head (3d5ce44).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6601      +/-   ##
==========================================
- Coverage   82.98%   82.97%   -0.01%     
==========================================
  Files         313      313              
  Lines       46073    46073              
==========================================
- Hits        38235    38231       -4     
- Misses       7838     7842       +4     
Flag Coverage Δ
ui-tests 40.04% <ø> (ø)
unitexamples-tests 71.26% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarcSkovMadsen
Copy link
Collaborator Author

MarcSkovMadsen commented Mar 28, 2024

I will leave this PR for now and wait for Philipp.

Co-authored-by: Philipp Rudiger <prudiger@anaconda.com>
@philippjfr philippjfr merged commit c5a7a9a into main Mar 28, 2024
2 of 3 checks passed
@philippjfr philippjfr deleted the enhancement/layout-build-docs branch March 28, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants