Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Tutorial Issues #6614

Merged
merged 11 commits into from
Apr 1, 2024
Merged

Fix Tutorial Issues #6614

merged 11 commits into from
Apr 1, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@MarcSkovMadsen MarcSkovMadsen commented Mar 29, 2024

Closes #6611

  • Addresses all of issues in Textual Reference Docs issues #6606 except that the docs are rendered with Pyodide. I would expect someone else to fix that.
  • Adds "missing" crossfiltering dashboard. It is one of the things that Panel/ HoloViews uniquely does really well and easily.

@MarcSkovMadsen MarcSkovMadsen added this to the v1.4.1 milestone Mar 29, 2024
Copy link

codecov bot commented Mar 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.95%. Comparing base (d59b23b) to head (6236f67).
Report is 4 commits behind head on main.

❗ Current head 6236f67 differs from pull request most recent head 9d3df31. Consider uploading reports for the commit 9d3df31 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6614      +/-   ##
==========================================
+ Coverage   82.94%   82.95%   +0.01%     
==========================================
  Files         313      313              
  Lines       46090    46090              
==========================================
+ Hits        38231    38236       +5     
+ Misses       7859     7854       -5     
Flag Coverage Δ
ui-tests 40.03% <ø> (ø)
unitexamples-tests 71.24% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Would prefer keeping fixes separate from new PRs. I'm going to merge this without the new tutorial section.

@philippjfr philippjfr marked this pull request as ready for review April 1, 2024 12:41
@philippjfr
Copy link
Member

Here's the new section, so it doesn't get lost:

build_crossfilter_dashboard.md

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for these fixes!

@philippjfr philippjfr merged commit aec0630 into main Apr 1, 2024
12 of 14 checks passed
@philippjfr philippjfr deleted the fix/tutorial-review branch April 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Panel tutorial Issues
2 participants