Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow full reset of dashboard builder layout #6625

Merged
merged 3 commits into from
Apr 1, 2024
Merged

Conversation

philippjfr
Copy link
Member

Previously the dashboard builder UI supported resets but only in a very limited way. Specifically resetting would happen live in the frontend and reset the order, unhide hidden components, reset the width to 100% but leave the height unchanged because the original height was effectively not recoverable. This PR instead forces a reload of the page and then tells the backend not to send the layout data, which means everything resets to what it was originally.

Fixes #6600

Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 82.85%. Comparing base (9bfff01) to head (450519a).
Report is 6 commits behind head on main.

Files Patch % Lines
panel/io/handlers.py 7.69% 12 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6625      +/-   ##
==========================================
- Coverage   82.96%   82.85%   -0.12%     
==========================================
  Files         313      313              
  Lines       46090    46134      +44     
==========================================
- Hits        38239    38224      -15     
- Misses       7851     7910      +59     
Flag Coverage Δ
ui-tests 40.00% <25.00%> (-0.03%) ⬇️
unitexamples-tests 71.13% <6.25%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 385617b into main Apr 1, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the editable_reset branch April 1, 2024 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Layout builder example not working
1 participant