Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace OrderedDict with dict #6637

Merged
merged 3 commits into from
Apr 2, 2024
Merged

Replace OrderedDict with dict #6637

merged 3 commits into from
Apr 2, 2024

Conversation

cdeil
Copy link
Contributor

@cdeil cdeil commented Apr 1, 2024

Modernise code base a bit by replacing OrderedDict with dict.
Should be complementary and not touch the lines from #6632 I hope.

panel/util/__init__.py Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 1, 2024

Codecov Report

Attention: Patch coverage is 84.78261% with 7 lines in your changes are missing coverage. Please review.

Project coverage is 82.88%. Comparing base (385617b) to head (1fbd0a8).
Report is 5 commits behind head on main.

Files Patch % Lines
panel/layout/grid.py 57.14% 3 Missing ⚠️
panel/io/notebook.py 0.00% 1 Missing ⚠️
panel/io/resources.py 0.00% 1 Missing ⚠️
panel/io/server.py 0.00% 1 Missing ⚠️
panel/layout/gridstack.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6637   +/-   ##
=======================================
  Coverage   82.88%   82.88%           
=======================================
  Files         313      313           
  Lines       46132    46119   -13     
=======================================
- Hits        38236    38228    -8     
+ Misses       7896     7891    -5     
Flag Coverage Δ
ui-tests 39.98% <17.39%> (-0.02%) ⬇️
unitexamples-tests 71.18% <84.78%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/tests/test_util.py Show resolved Hide resolved
panel/util/__init__.py Outdated Show resolved Hide resolved
panel/widgets/select.py Outdated Show resolved Hide resolved
panel/widgets/select.py Outdated Show resolved Hide resolved
panel/widgets/select.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit c09fc75 into holoviz:main Apr 2, 2024
14 of 15 checks passed
ahuang11 pushed a commit that referenced this pull request Apr 2, 2024
ahuang11 pushed a commit that referenced this pull request Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants