Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow rendering raw IPython.display output in dashboard builder #6657

Merged
merged 1 commit into from Apr 4, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 3, 2024

This PR adds a few improvements to the dashboard builder UI:

  • We now patch the IPython.display.display utility (in addition to the display utility) with our custom handler
  • We add handling for raw mimebundles in our patched utility
  • We add a mime renderer for the Plotly mime type
  • We add a minimum height for Plotly output since the initial sizing may not work

As an example, this allows us to do stuff like this:

Screenshot 2024-04-03 at 14 57 33

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 11.36364% with 39 lines in your changes are missing coverage. Please review.

Project coverage is 81.75%. Comparing base (510d212) to head (d62a770).

Files Patch % Lines
panel/io/handlers.py 10.00% 36 Missing ⚠️
panel/io/mime_render.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6657      +/-   ##
==========================================
- Coverage   82.84%   81.75%   -1.10%     
==========================================
  Files         313      313              
  Lines       46119    46154      +35     
==========================================
- Hits        38207    37732     -475     
- Misses       7912     8422     +510     
Flag Coverage Δ
ui-tests 36.90% <11.36%> (-3.09%) ⬇️
unitexamples-tests 71.12% <11.36%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr added this to the v1.4.1 milestone Apr 4, 2024
@philippjfr philippjfr merged commit 0e19008 into main Apr 4, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the patch_raw_display branch April 4, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant