Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Tabulator HTMLTemplateFormatter to reference multiple columns #6663

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

philippjfr
Copy link
Member

Fixes #6654

@philippjfr
Copy link
Member Author

pre-commit.ci autofix

panel/models/tabulator.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 40.16%. Comparing base (510d212) to head (0f91311).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6663       +/-   ##
===========================================
- Coverage   82.84%   40.16%   -42.69%     
===========================================
  Files         313      313               
  Lines       46119    46127        +8     
===========================================
- Hits        38207    18526    -19681     
- Misses       7912    27601    +19689     
Flag Coverage Δ
ui-tests 39.98% <100.00%> (-0.01%) ⬇️
unitexamples-tests 22.13% <0.00%> (-49.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit a417daa into main Apr 4, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the tabulator_format_multi_column branch April 4, 2024 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tabulator: HTMLTemplateFormatter not working when referencing other columns
1 participant