Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure loading.css is included in converted app without template #6665

Merged
merged 1 commit into from Apr 4, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 4, 2024

Fixes #6652

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

Attention: Patch coverage is 21.42857% with 11 lines in your changes are missing coverage. Please review.

Project coverage is 40.12%. Comparing base (510d212) to head (df8beb9).
Report is 5 commits behind head on main.

Files Patch % Lines
panel/io/convert.py 21.42% 11 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6665       +/-   ##
===========================================
- Coverage   82.84%   40.12%   -42.72%     
===========================================
  Files         313      313               
  Lines       46119    46160       +41     
===========================================
- Hits        38207    18522    -19685     
- Misses       7912    27638    +19726     
Flag Coverage Δ
ui-tests 39.95% <21.42%> (-0.04%) ⬇️
unitexamples-tests 22.13% <21.42%> (-49.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit ba01468 into main Apr 4, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the convert_no_template_loading_css branch April 4, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No loading spinner with panel convert --to pyodide
1 participant