Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve snapping behavior and add undo in EditableTemplate #6687

Merged
merged 6 commits into from
Apr 8, 2024

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Apr 8, 2024

Previously there was a bug in the snapping behavior which meant that often it would just snap to itself or an invisible element. This fixes both cases and also adds an undo button to the dashboard builder.

Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 70.82%. Comparing base (5f77d4f) to head (27334cf).
Report is 1 commits behind head on main.

❗ Current head 27334cf differs from pull request most recent head 79dd353. Consider uploading reports for the commit 79dd353 to get more accurate results

Files Patch % Lines
panel/io/handlers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6687      +/-   ##
==========================================
- Coverage   71.08%   70.82%   -0.26%     
==========================================
  Files         313      305       -8     
  Lines       46177    45985     -192     
==========================================
- Hits        32824    32570     -254     
- Misses      13353    13415      +62     
Flag Coverage Δ
unitexamples-tests 70.82% <0.00%> (-0.26%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr changed the title Improve snapping behavior in EditableTemplate Improve snapping behavior and add undo in EditableTemplate Apr 8, 2024
@philippjfr philippjfr merged commit 94b8f51 into main Apr 8, 2024
14 checks passed
@philippjfr philippjfr deleted the editable_snapping_fix branch April 8, 2024 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant