Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow adding JS callbacks in ChatInterface.button_properties #6706

Merged
merged 5 commits into from
Apr 19, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Apr 10, 2024

My use case is to download all messages

Screen.Recording.2024-04-10.at.1.28.29.PM.mov

Copy link

codecov bot commented Apr 10, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 37.05%. Comparing base (76c911a) to head (1127b7d).
Report is 21 commits behind head on main.

❗ Current head 1127b7d differs from pull request most recent head f282695. Consider uploading reports for the commit f282695 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6706      +/-   ##
==========================================
- Coverage   40.01%   37.05%   -2.97%     
==========================================
  Files         313      305       -8     
  Lines       46194    46048     -146     
==========================================
- Hits        18486    17062    -1424     
- Misses      27708    28986    +1278     
Flag Coverage Δ
ui-tests 37.05% <100.00%> (-2.97%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/chat/interface.py Outdated Show resolved Hide resolved
@philippjfr
Copy link
Member

Test still failing.

@philippjfr philippjfr merged commit 373b846 into main Apr 19, 2024
14 checks passed
@philippjfr philippjfr deleted the add_js_buttons_chat branch April 19, 2024 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants