Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not include placeholder in serialize and properly replace placeholder for streams #6734

Merged
merged 4 commits into from Apr 17, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Apr 15, 2024

Before, the placeholder disappeared, but no message.

Screen.Recording.2024-04-15.at.3.38.59.PM.mov

After fixes:

Screen.Recording.2024-04-15.at.3.39.32.PM.mov

@ahuang11 ahuang11 added this to the v1.4.2 milestone Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 9.09091% with 20 lines in your changes are missing coverage. Please review.

Project coverage is 37.00%. Comparing base (76c911a) to head (9b4f8ed).
Report is 8 commits behind head on main.

❗ Current head 9b4f8ed differs from pull request most recent head 068b479. Consider uploading reports for the commit 068b479 to get more accurate results

Files Patch % Lines
panel/tests/chat/test_feed.py 10.00% 18 Missing ⚠️
panel/chat/feed.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6734      +/-   ##
==========================================
- Coverage   40.01%   37.00%   -3.02%     
==========================================
  Files         313      305       -8     
  Lines       46194    46052     -142     
==========================================
- Hits        18486    17040    -1446     
- Misses      27708    29012    +1304     
Flag Coverage Δ
ui-tests 37.00% <9.09%> (-3.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

panel/chat/feed.py Outdated Show resolved Hide resolved
panel/chat/feed.py Outdated Show resolved Hide resolved
@philippjfr philippjfr merged commit 5329ae1 into main Apr 17, 2024
14 checks passed
@philippjfr philippjfr deleted the chat_feed_tweaks branch April 17, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants